mmiklavc commented on issue #1409: METRON-2112 Normalize parser original_string handling URL: https://github.com/apache/metron/pull/1409#issuecomment-494980456 > Troubleshooting validation issues (as evidenced here) is not easy and is probably a separate issue. I will file a Jira on that. > > The question is, why would someone ever set the global option to false? If instead the `original_string` defaulted to the bytes coming out of Kafka then validation would never fail because `original_string` would always be present. Wouldn't that be better than failing validation? Yes, absolutely - that's literally what the flag `parser.original.string.global` does - it defaults to true, and will add original_string if not present. The purpose of this PR was to address a very specific case - the jsonmapparser regression due to the JsonPath and JSONObject use for the k sub-messages potentially returned. I wanted to provide a way forward that maintained that original_string if people still wanted it - per the DISCUSS thread, I gathered that was the case from @ottobackwards 's +1. I'm also happy to get rid of the options altogether and effectively force the value through, but that's not what came out of the DISCUSS thread.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
