sardell commented on issue #1380: METRON-1253: Manual pasting of timestamps 
into the timestamp picker
URL: https://github.com/apache/metron/pull/1380#issuecomment-496797322
 
 
   I do think my suggestion is creating more work that is clearly out of scope 
of this specific fix for the datepicker. I respectfully disagree that these 
changes aren't necessary or worth the effort. Maybe I'm oversimplifying this, 
but you could add a HostListener to listen for clicks outside of the 
datepicker. For example: 
https://stackoverflow.com/questions/40107008/detect-click-outside-angular-component.
 The Cypress tests are probably broken with the suggested changes because they 
are targeting the input vs. the icon to open the calendar.
   
   All that said, I'm going to give this a +1, as this work clearly addresses 
the problem you set out to fix (copy and pasting dates in the datepicker). I've 
created a separate ticket to address the UX issues with the datepicker: 
https://issues.apache.org/jira/browse/METRON-2146

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to