mmiklavc commented on issue #1436: METRON-2149: Shaded jar classifier is not 
consistent
URL: https://github.com/apache/metron/pull/1436#issuecomment-508237241
 
 
   > For example, if a module depends on stellar-common, stellar-common would 
be set to provided. This way we wouldn't need to exclude dependencies that are 
rewritten. This would also mean we need to go with the option of adding the 
uber jars to the classpath separately (option 2 above) but I think that is the 
correct approach anyways.
   
   This sounds sensible to me. I think the challenge with any approach we take 
here is that it's going to require us to effectively get it 80% of the way done 
before we find out if there are any gotchas we didn't think of.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to