mmiklavc commented on issue #1341: METRON-614: Eliminate use of the default 
Charset
URL: https://github.com/apache/metron/pull/1341#issuecomment-510614431
 
 
   > I think that is reasonable, but I would want to see tests with alternate 
charsets
   
   e.g. test that we can read in ISO-8859-1 and properly convert to UTF-8? 
Yeah, that makes sense. @justinleet I'm happy to work on that and submit a PR 
against your PR. I think we just need some conflict resolution before I tackle 
that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to