mmiklavc commented on a change in pull request #1465: METRON-2172 Solr Updates Not Tested in Integration Test URL: https://github.com/apache/metron/pull/1465#discussion_r305116238
########## File path: metron-platform/metron-solr/metron-solr-common/src/test/java/org/apache/metron/solr/dao/SolrSearchDaoTest.java ########## @@ -510,5 +512,13 @@ public void getGroupResultsShouldProperlyReturnGroupResults() { assertNull(level2GroupResults.get(1).getGroupResults()); } - + private SolrDocument createSolrDocument(String sensorType, Long timestamp) { + SolrDocument solrDocument = new SolrDocument(); + solrDocument.addField(SolrDao.VERSION_FIELD, 1.0); + solrDocument.addField(Constants.GUID, UUID.randomUUID().toString()); + solrDocument.addField(Constants.SENSOR_TYPE, sensorType); + solrDocument.addField(Constants.Fields.TIMESTAMP.getName(), timestamp); + solrDocument.addField("ip_src_addr", "192.168.1.1"); Review comment: `Constants.Fields.SRC_ADDR` https://github.com/apache/metron/blob/3754ff33f6cd149ffca57474d744e0298d4c172a/metron-platform/metron-common/src/main/java/org/apache/metron/common/Constants.java#L52 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services