mmiklavc commented on a change in pull request #1458: METRON-2177 Upgrade Profiler for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1458#discussion_r307500220
########## File path: metron-analytics/metron-profiler-client/src/main/java/org/apache/metron/profiler/client/HBaseProfilerClientFactory.java ########## @@ -0,0 +1,98 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ +package org.apache.metron.profiler.client; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.HBaseConfiguration; +import org.apache.metron.hbase.client.HBaseClient; +import org.apache.metron.hbase.client.HBaseClientFactory; +import org.apache.metron.hbase.client.HBaseConnectionFactory; +import org.apache.metron.hbase.client.HBaseTableClientFactory; +import org.apache.metron.profiler.hbase.ColumnBuilder; +import org.apache.metron.profiler.hbase.RowKeyBuilder; +import org.apache.metron.profiler.hbase.SaltyRowKeyBuilder; +import org.apache.metron.profiler.hbase.ValueOnlyColumnBuilder; + +import java.util.Map; +import java.util.concurrent.TimeUnit; + +import static org.apache.metron.profiler.client.stellar.ProfilerClientConfig.PROFILER_COLUMN_FAMILY; +import static org.apache.metron.profiler.client.stellar.ProfilerClientConfig.PROFILER_HBASE_TABLE; +import static org.apache.metron.profiler.client.stellar.ProfilerClientConfig.PROFILER_HBASE_CONNECTION_FACTORY; +import static org.apache.metron.profiler.client.stellar.ProfilerClientConfig.PROFILER_SALT_DIVISOR; +import static org.apache.metron.profiler.client.stellar.Util.getPeriodDurationInMillis; + +/** + * Creates an {@link HBaseProfilerClient}. + */ +public class HBaseProfilerClientFactory implements ProfilerClientFactory { + + private HBaseClientFactory hBaseClientFactory; + + public HBaseProfilerClientFactory() { + this(new HBaseTableClientFactory()); + } + + public HBaseProfilerClientFactory(HBaseClientFactory hBaseClientFactory) { + this.hBaseClientFactory = hBaseClientFactory; + } + + @Override + public HBaseProfilerClient create(Map<String, Object> globals) { Review comment: > Keep in mind, I didn't invent the HBaseClient API as part of this HDP 3.1 upgrade effort. I am just reusing what we already have in [master](https://github.com/apache/metron/blob/a2a46e6567c78e5066c0d3360d7838d1a5851fa7/metron-platform/metron-hbase/metron-hbase-common/src/main/java/org/apache/metron/hbase/client/HBaseClient.java#L145). Agreed, and I understand that we had this previously. When I had gone through the coprocessor work I noticed that we had a few implementations of the client out there. It wasn't clear to me then whether it was the right time to consolidate those or not. Rather than introduce yet another implementation, I did my best to expand on the most robust of those options. Considering the amount of churn here, and having had at least a few iterations on it already to date, I think we should seriously consider introducing some refactoring work prior to closing out the feature branch. It doesn't have to be in this PR, but as we're winding down I'd like to come back to it and discuss this a bit further. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
