sardell commented on a change in pull request #1430: METRON-2139: Refactoring sensor-parser-config.component and wire NgRx URL: https://github.com/apache/metron/pull/1430#discussion_r308683716
########## File path: metron-interface/metron-config/src/app/sensors/reducers/sensors.reducers.ts ########## @@ -0,0 +1,638 @@ +/** Review comment: @ruffle1986 I feel like we should break down this large reducer file into multiple files, as well as extract out the interfaces. I don't think it is necessarily an item that needs to be fixed for this PR to be accepted, but I do think it would make it easier to digest this code. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
