mmiklavc commented on a change in pull request #1475: METRON-2197 Add debugging
info output for Solr queries
URL: https://github.com/apache/metron/pull/1475#discussion_r309764287
##########
File path:
metron-platform/metron-solr/metron-solr-common/src/main/java/org/apache/metron/solr/dao/SolrSearchDao.java
##########
@@ -91,29 +106,28 @@ public SearchResponse search(SearchRequest searchRequest,
String fieldList)
throw new InvalidSearchException(
"Search result size must be less than " +
accessConfig.getMaxSearchResults());
}
- try {
- SolrQuery query = buildSearchRequest(searchRequest, fieldList);
- QueryResponse response = client.query(query);
- return buildSearchResponse(searchRequest, response);
- } catch (SolrException | IOException | SolrServerException e) {
- String msg = e.getMessage();
- LOG.error(msg, e);
- throw new InvalidSearchException(msg, e);
+ }
+
Review comment:
Hm, that's true. The main target for this change is folks doing performance
tuning, but I think you're right. If you turn this on to see prod runtime
issues, having many clients is going to show these logs in a mixed order. How
about a random hash to prepend the lines with a random ID? At least the info
can be grouped then. Or I could build this into one big massive string so
there's only one log entry?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
