justinleet commented on a change in pull request #1341: METRON-614: Eliminate
use of the default Charset
URL: https://github.com/apache/metron/pull/1341#discussion_r312476398
##########
File path:
metron-platform/metron-parsing/metron-parsers-common/src/main/java/org/apache/metron/parsers/ParserRunnerImpl.java
##########
@@ -255,7 +256,7 @@ private void
initializeParsers(Supplier<ParserConfigurations> parserConfigSuppli
if (!message.containsKey(Constants.GUID)) {
message.put(Constants.GUID, UUID.randomUUID().toString());
}
- message.putIfAbsent(Fields.ORIGINAL.getName(), new
String(rawMessage.getMessage()));
+ message.putIfAbsent(Fields.ORIGINAL.getName(), new
String(rawMessage.getMessage(), StandardCharsets.UTF_8));
Review comment:
This needs to care about the underlying parser's format, right? This is
pulling the raw message, but that might not be `UTF_8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
