mmiklavc commented on a change in pull request #1341: METRON-614: Eliminate use 
of the default Charset
URL: https://github.com/apache/metron/pull/1341#discussion_r313055407
 
 

 ##########
 File path: 
metron-platform/metron-parsing/metron-parsers-common/src/main/java/org/apache/metron/parsers/json/JSONMapParser.java
 ##########
 @@ -202,7 +204,7 @@ public void init() {
       }
       return Collections.unmodifiableList(parsedMessages);
     } catch (Throwable e) {
-      String message = "Unable to parse " + new String(rawMessage) + ": " + 
e.getMessage();
+      String message = "Unable to parse " + new String(rawMessage, 
StandardCharsets.UTF_8) + ": " + e.getMessage();
 
 Review comment:
   Ok @justinleet - I posted an updated PR against your PR. Please review and 
see if that addresses this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to