mmiklavc commented on issue #1474: METRON-2201: The description for the IS_IP method default behavior needs to corrected as per implementation URL: https://github.com/apache/metron/pull/1474#issuecomment-520930529 For reference, the underlying implementation of this validator https://commons.apache.org/proper/commons-validator/apidocs/src-html/org/apache/commons/validator/routines/InetAddressValidator.html performs an "or" on IPV4/IPV6 ``` 077 public boolean isValid(String inetAddress) { 078 return isValidInet4Address(inetAddress) || isValidInet6Address(inetAddress); 079 } ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services