nickwallen commented on issue #1470: METRON-2193 Upgrade Enrichments for HBase 2.0.2 URL: https://github.com/apache/metron/pull/1470#issuecomment-521045619 > Replacing deprecated API calls against master Many of the changes here are not backwards compatible which prevents me from introducing them against master, unfortunately. > This is also a decent time to, instead of replacing the mistake of passing around HTableInterface to create a key-value store abstraction which you can pass around instead that supports scan, get and put. For the work on this feature branch, the `HBaseClient` is that common abstraction. It was already in the code base and was used in a few different areas, so I leveraged that. As part of the upgrade, I've tried to port over as many functions as possible to use the `HBaseClient`. See #1456 for more context. There are still a few remaining places that don't directly use an `HBaseClient`, but instead pass around HBase abstractions like `Table` as they always have. There is just a limit to how much time I can spend on this upgrade. The ones that I have not ported to `HBaseClient` were ones where the manner in which they are tested did not force my hand in transitioning them to `HBaseClient`. For example, we have to integration test "streaming enrichments" against HBase, Kafka and Storm. With our current IT approach, these all have to run in memory. But we cannot run HBase in-memory with Storm and Kafka, which is why the integration tests in `master` actually use a "mock" HBase instance. In these cases since HBase cannot co-exist in memory, these classes were ported to `HBaseClient` and so ultimately use a `FakeHBaseClient`in the IT. For those that were not ported to `HbaseClient`, I'd like us to upgrade or deprecate those after this feature branch is complete.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
