mmiklavc commented on a change in pull request #1506: METRON-2188 Upgrade to 
HBase 2.0.2
URL: https://github.com/apache/metron/pull/1506#discussion_r322981358
 
 

 ##########
 File path: metron-platform/metron-hbase/metron-hbase-common/pom.xml
 ##########
 @@ -52,6 +52,10 @@
                     <groupId>org.slf4j</groupId>
                     <artifactId>slf4j-log4j12</artifactId>
                 </exclusion>
+                <exclusion>
 
 Review comment:
   Any thoughts, comments, or lessons learned on how you came around to the 
various exclusions? With our recent maven/pom changes, the process changes 
slightly. We haven't done the best job sharing some of this dependency tribal 
knowledge with the broader dev community for Metron, so it's probably worth 
having some details in this PR that we can use in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to