nickwallen commented on a change in pull request #1506: METRON-2188 Upgrade to
HBase 2.0.2
URL: https://github.com/apache/metron/pull/1506#discussion_r323228816
##########
File path: metron-stellar/stellar-common/pom.xml
##########
@@ -331,6 +331,10 @@
<pattern>com.google.common</pattern>
<shadedPattern>org.apache.metron.guava.${guava_version}</shadedPattern>
</relocation>
+ <relocation>
+ <pattern>com.google.thirdparty</pattern>
Review comment:
Originally, we only relocated `com.google.common` which is only a subset of
the code base in the Guava libraries. The following error arises when
relocated Guava code needs to refer to non-relocated Guava code.
```
Caused by: org.apache.metron.stellar.dsl.ParseException: Unable to parse:
DOMAIN_REMOVE_TLD(domain) due to: EXACT with relevant variables
domain=google.com
at
org.apache.metron.stellar.common.BaseStellarProcessor.createException(BaseStellarProcessor.java:173)
at
org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:154)
at
org.apache.metron.dataloads.extractor.TransformFilterExtractorDecorator.transform(TransformFilterExtractorDecorator.java:285)
at
org.apache.metron.dataloads.extractor.TransformFilterExtractorDecorator.updateLookupKV(TransformFilterExtractorDecorator.java:263)
at
org.apache.metron.dataloads.extractor.TransformFilterExtractorDecorator.extract(TransformFilterExtractorDecorator.java:242)
at
org.apache.metron.dataloads.nonbulk.flatfile.importer.LocalSummarizer.extract(LocalSummarizer.java:115)
at
org.apache.metron.dataloads.nonbulk.flatfile.importer.LocalSummarizer.extract(LocalSummarizer.java:42)
at
org.apache.metron.dataloads.nonbulk.flatfile.importer.AbstractLocalImporter.lambda$null$1(AbstractLocalImporter.java:107)
at
java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
at
java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:291)
at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731)
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
at
java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
at
java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)
Caused by: java.lang.NoSuchFieldError: EXACT
at
org.apache.metron.guava.17.0.net.InternetDomainName.findPublicSuffix(InternetDomainName.java:173)
at
org.apache.metron.guava.17.0.net.InternetDomainName.<init>(InternetDomainName.java:158)
at
org.apache.metron.guava.17.0.net.InternetDomainName.from(InternetDomainName.java:213)
at
org.apache.metron.stellar.dsl.functions.NetworkFunctions.toDomainName(NetworkFunctions.java:271)
at
org.apache.metron.stellar.dsl.functions.NetworkFunctions.access$000(NetworkFunctions.java:34)
at
org.apache.metron.stellar.dsl.functions.NetworkFunctions$RemoveTLD.apply(NetworkFunctions.java:120)
at
org.apache.metron.stellar.dsl.BaseStellarFunction.apply(BaseStellarFunction.java:30)
at
org.apache.metron.stellar.common.StellarCompiler.lambda$exitTransformationFunc$13(StellarCompiler.java:664)
at
org.apache.metron.stellar.common.StellarCompiler$Expression.apply(StellarCompiler.java:259)
at
org.apache.metron.stellar.common.BaseStellarProcessor.parse(BaseStellarProcessor.java:151)
... 15 more
```
We already have a similar relocation in
[metron-storm-kafka-override](https://github.com/apache/metron/blob/722eb66a6a6a1208185e238f29864d95c673f404/metron-platform/metron-storm-kafka-override/pom.xml#L135-L137).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
