mmiklavc commented on a change in pull request #1506: METRON-2188 Upgrade to 
HBase 2.0.2
URL: https://github.com/apache/metron/pull/1506#discussion_r323464592
 
 

 ##########
 File path: metron-stellar/stellar-common/pom.xml
 ##########
 @@ -331,6 +331,10 @@
                                     <pattern>com.google.common</pattern>
                                     
<shadedPattern>org.apache.metron.guava.${guava_version}</shadedPattern>
                                 </relocation>
+                                <relocation>
+                                    <pattern>com.google.thirdparty</pattern>
 
 Review comment:
   Ok, thanks for confirming. Just thought it looked a bit fishy to see 
`com.google.thirdparty` - looked like an existing relocation of ours. I did not 
realize that Guava also has that package in its contents:
   
   - `com.google.common`
   - `com.google.thirdparty.publicsuffix`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to