tiborm commented on a change in pull request #1514: METRON-2190: [UI] Alerts
UI: Indicating loading and preventing parallel requests
URL: https://github.com/apache/metron/pull/1514#discussion_r327003814
##########
File path:
metron-interface/metron-alerts/src/app/alerts/alerts-list/alerts-list.component.ts
##########
@@ -271,9 +298,24 @@ export class AlertsListComponent implements OnInit,
OnDestroy {
this.staleDataState = true;
}
- onConfigRowsChange() {
- this.searchService.interval = this.refreshInterval;
- this.search();
Review comment:
onConfigRowChange was triggering a manual query. Auto polling interval
setting is part of row config. It make no sense to trigger a manual query when
user change a settings belong to auto polling. I was separated this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
