sardell commented on a change in pull request #1553: METRON-2306: [UI] Grok 
parsers' have duplicate timestampField
URL: https://github.com/apache/metron/pull/1553#discussion_r342186993
 
 

 ##########
 File path: 
metron-interface/metron-config/src/app/sensors/sensor-parser-config/sensor-parser-config.component.ts
 ##########
 @@ -191,8 +192,8 @@ export class SensorParserConfigComponent implements OnInit 
{
 
   ngOnInit() {
     this.route.params.subscribe(params => {
-      let id = params['id'];
-      this.init(id);
+      this.paramsID = params['id'];
 
 Review comment:
   Storing the id in a class property allows me to use it when evaluating 
whether or not to populate the parserConfig object with the timestampField 
property and default `timestamp` value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to