justinleet commented on a change in pull request #1554: METRON-2307: Migrate to
JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r346642230
##########
File path: metron-stellar/stellar-common/pom.xml
##########
@@ -230,11 +230,29 @@
<version>${global_httpclient_version}</version>
</dependency>
<dependency>
- <!-- junit dependency added with default scope to allow inclusion
of StellarProcessorUtils in main jar.
- It is excluded from the uber-jar. -->
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <version>${global_junit_version}</version>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest-core</artifactId>
+ <version>${global_hamcrest_version}</version>
+ <scope>test</scope>
+ </dependency>
+ <!-- junit dependency added with default scope to allow inclusion of
StellarProcessorUtils in main jar.
+ It is excluded from the uber-jar. -->
+ <dependency>
Review comment:
@nickwallen Why are we using JUnit assertions in `StellarProcessorUtils`,
rather than either throwing something else (and an `AssertionError` from `fail`
is an`Error` anyway under the hood if these checks fail)? It seems really odd
that we're using JUnit utilities to enforce correctness of `src`.
If we were to migrate to something else(and it doesn't have to be in this
PR), it'd mean this dep gets dropped back down to test, and cleans up the uber
jar definition. I just want to make sure I'm not misunderstanding something
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
