sardell commented on issue #1560: METRON-2316: [UI] Drag drop sorting for the selected fields in the Alerts UI URL: https://github.com/apache/metron/pull/1560#issuecomment-554759943 @ruffle1986 Once again, really nice work. Thanks for the thorough documentation of what you did. Not only does it help with my understanding, it also will help future users understand what we are doing here since we are deviating from the normal use of Dragula (for the good reason, as you pointed out). I'm good with everything you've done, but I'm wondering if we should keep the up/down arrows for arranging columns. On the one hand, part of me wants to keep it for accessibility reasons (although we need to make it tab-able and add a key event binding to make that happen). On the other hand, I wonder if we are actually confusing users by keeping the up/down arrows. Maybe we should go with the first suggestion since it's a low amount of effort, and if we get feedback in Slack or the mailing list that it's confusing users, we can remove it. Are you good with this?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
