nickwallen edited a comment on issue #1550: METRON-2304: Update node and npm version to LTS releases URL: https://github.com/apache/metron/pull/1550#issuecomment-555510328 It is failing when building the RPMs. It is really difficult to discern error messages via the Ansible output, so what I usually do is figure out where it is failing in the build process, then just run that command myself on the command line. When building the RPMS, we get this error output. ``` $ cd metron-deployment/ $ mvn clean package -Pbuild-rpms ... RPM build errors: error: Installed (but unpackaged) file(s) found: /usr/metron/0.7.2/web/expressjs/package-lock.json Macro %_prerelease has empty body Macro %_prerelease has empty body Installed (but unpackaged) file(s) found: /usr/metron/0.7.2/web/expressjs/package-lock.json RPM build errors encountered ``` I see there is a `package-lock.json` that is present in the location where the RPMs are being packaged. ``` $ find metron-deployment/packaging/ -name package-lock.json metron-deployment/packaging//docker/rpm-docker/BUILDROOT/metron-0.7.2-root/usr/metron/0.7.2/web/expressjs/package-lock.json ``` I also see `package-lock.json` present in the root of the web projects. ``` $ find metron-interface/ -name package-lock.json ... metron-interface//metron-alerts/package-lock.json ... metron-interface//metron-config/package-lock.json ``` The problem is that I do not see a `package-lock.json` defined in the `metron.spec` file. If a file is not listed in the spec, but an attempt is made to package it, the build will fail. * Am I correct in assuming that we should NOT be including this file in the RPMs? * Did something change in the upgrade in regards to this file?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
