ottobackwards commented on a change in pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#discussion_r420274006
########## File path: README.md ########## @@ -16,7 +16,7 @@ This software is a part of the [Apache Metron](http://metron.apache.org/) projec `zkg` is the preferred mechanism for installing this plugin, as it will dynamically retrieve, build, test, and load the plugin. Note, that you will still need to [activate](#activation) and configure the plugin after your installation. -1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against the latest release of librdkafka, which at the time of this writing is v1.4.2. +1. Install [librdkafka](https://github.com/edenhill/librdkafka), a native client library for Kafka. This plugin has been tested against librdkafka v1.4.2. Review comment: Ok, I wasn't thinking of this as a question of the release or release process, I'm just thinking that with 'stable master', this needs to be correct (as of this commit ) The question of cutting a release off of master or not is separate. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
