[
https://issues.apache.org/jira/browse/METRON-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222021#comment-15222021
]
ASF GitHub Bot commented on METRON-93:
--------------------------------------
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/66#discussion_r58237558
--- Diff:
metron-streaming/Metron-DataLoads/src/main/java/org/apache/metron/dataloads/hbase/mr/PrunerMapper.java
---
@@ -48,7 +48,7 @@ public void setup(Context context) throws IOException
}
try {
tracker =
AccessTrackerUtil.INSTANCE.loadAll(AccessTrackerUtil.INSTANCE.loadAll(table,
atCF, atName, timestamp));
- } catch (Exception e) {
+ } catch (Throwable e) {
--- End diff --
This is just a style thing. It's going to throw a runtime exception
regardless and kill the task, but I wanted it to be clear in the logs that
it was due to not bing able to load the access tracker stuff (as opposed to
an OOM exception).
On Fri, Apr 1, 2016 at 1:18 PM, David Lyle <[email protected]> wrote:
> In
>
metron-streaming/Metron-DataLoads/src/main/java/org/apache/metron/dataloads/hbase/mr/PrunerMapper.java
> <https://github.com/apache/incubator-metron/pull/66#discussion_r58236854>:
>
> > @@ -48,7 +48,7 @@ public void setup(Context context) throws IOException
> > }
> > try {
> > tracker =
AccessTrackerUtil.INSTANCE.loadAll(AccessTrackerUtil.INSTANCE.loadAll(table,
atCF, atName, timestamp));
> > - } catch (Exception e) {
> > + } catch (Throwable e) {
>
> Was this changed to deliberately catch subclasses of Error?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
>
<https://github.com/apache/incubator-metron/pull/66/files/b4fc71e0a18ba9f2b897c3b01e16093903ed100a#r58236854>
>
> Generalize the HBase threat intel infrastructure to support enrichments
> -----------------------------------------------------------------------
>
> Key: METRON-93
> URL: https://issues.apache.org/jira/browse/METRON-93
> Project: Metron
> Issue Type: Improvement
> Reporter: Casey Stella
> Assignee: Casey Stella
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> As it stands, the threat intel infrastructure is awkward. Namely, different
> threat intelligence sources must be pushed into separate hbase tables
> (malicious_ips separate form malicious_hosts, for instance). We'd rather
> have one table where the type is brought into the rowkey. Since this
> infrastructure is generalized, also add a simple hbase enrichment adapter.
> Furthermore, the configuration for a new enrichment should be added to
> zookeeper as part of the data load.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
