[
https://issues.apache.org/jira/browse/METRON-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901321#comment-15901321
]
ASF GitHub Bot commented on METRON-726:
---------------------------------------
Github user justinleet commented on the issue:
https://github.com/apache/incubator-metron/pull/459
@mmiklavc @dlyle65535 I just updated the PR to work with metron-interface
(since it came in after this PR). I also merged in master to get some
miscellaneous fixes (including in the site-book).
I also added site-book as a component module, so that it gets built at the
same time and gets pulled into the site (and can be clicked into when spun up).
We may or may not want to leave that, depending on if we want that in the base
mvn clean install. Let me know if there's a preference. It's a one line
change to revert that.
Finally, I added Javadoc report generation to the top level POM, so it's
integrated directly with the site now (feel free to spin it up again and click
into Javadocs!)
@mattf-horton This PR now also includes a fatal Javadoc fix. I think at
this point, it's mostly the integration (unless something else breaks in the
meantime). I think at this point, all the reporting works and gets done in one
shot.
I haven't created the ticket for doing something nice with the outputs of
this, just because I didn't know if there would be discussion. I'll go ahead
and create this, since it seems like people are on board. Matt, if you have
any insight into what the appropriate integrations are (e.g. what other
projects do), I'd love to add that to the ticket to give whoever picks it up a
little extra guidance.
> Clean up mvn site generation
> ----------------------------
>
> Key: METRON-726
> URL: https://issues.apache.org/jira/browse/METRON-726
> Project: Metron
> Issue Type: Bug
> Reporter: Justin Leet
> Assignee: Justin Leet
> Priority: Minor
>
> Right now there's a couple issues with running mvn:site. The most obvious is
> that EMMA appears to not work at all, but in attempting to fix that, several
> other issues came to light.
> Error seen:
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.3:site (default-site) on project
> metron-maas-common: failed to get report for
> org.codehaus.mojo:emma-maven-plugin: Failed to execute goal
> org.codehaus.mojo:emma-maven-plugin:1.0-alpha-3:instrument (report:emma) on
> project metron-maas-common: Execution report:emma of goal
> org.codehaus.mojo:emma-maven-plugin:1.0-alpha-3:instrument failed:
> CONSTANT_info: invalid tag value [18] -> [Help 1]
> {code}
> After commenting out everything EMMA, there are still some issues seen:
> {code}
> [WARNING] Unable to process class
> org/apache/metron/test/converters/BinaryConverters.class in JarAnalyzer File
> /Users/jleet/.m2/repository/org/apache/metron/metron-test-utilities/0.3.1/metron-test-utilities-0.3.1.jar
> org.apache.bcel.classfile.ClassFormatException: Invalid byte tag in constant
> pool: 18
> {code}
> This seems to be a Java 8 issue, which means that EMMA likely is impossible
> to make work. I'm unsure that's the root cause, but given the age of EMMA
> plus (the outdated version of) BCEL thowing a very similar issue implies that
> the Java version is related. This also implies that our {{mvn site}} hasn't
> worked in a long time.
> Cleaning this up should include at least
> * Getting code coverage working again
> * Consolidating reporting in our poms. A lot of it is repeated everywhere we
> have Java.
> * Ensure we can actually generate and look through the site.
> * METRON-725 fixes Javadoc, so reporting will still have issues until that is
> taken care of.
> * Apparently checkstyle got dropped at some point. It's easy enough to add
> in, and can be taken care of here.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
