[ https://issues.apache.org/jira/browse/METRON-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943410#comment-15943410 ]
ASF GitHub Bot commented on METRON-773: --------------------------------------- Github user cestella commented on a diff in the pull request: https://github.com/apache/incubator-metron/pull/491#discussion_r108192355 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/KafkaControllerIntegrationTest.java --- @@ -54,135 +58,165 @@ @ActiveProfiles(TEST_PROFILE) public class KafkaControllerIntegrationTest { - @Autowired - private KafkaComponent kafkaWithZKComponent; - - class SampleDataRunner implements Runnable { - - private boolean stop = false; - private String path = "../../metron-platform/metron-integration-test/src/main/sample/data/bro/raw/BroExampleOutput"; - - @Override - public void run() { - SampleDataGenerator broSampleDataGenerator = new SampleDataGenerator(); - broSampleDataGenerator.setBrokerUrl(kafkaWithZKComponent.getBrokerList()); - broSampleDataGenerator.setNum(1); - broSampleDataGenerator.setSelectedSensorType("bro"); - broSampleDataGenerator.setDelay(0); - try { - while(!stop) { - broSampleDataGenerator.generateSampleData(path); - } - } catch (IOException e) { - e.printStackTrace(); - } catch (ParseException e) { - e.printStackTrace(); - } - } - - public void stop() { - stop = true; + private static final int KAFKA_RETRY = 10; + @Autowired + private KafkaComponent kafkaWithZKComponent; + + class SampleDataRunner implements Runnable { + + private boolean stop = false; + private String path = "../../metron-platform/metron-integration-test/src/main/sample/data/bro/raw/BroExampleOutput"; + + @Override + public void run() { + SampleDataGenerator broSampleDataGenerator = new SampleDataGenerator(); + broSampleDataGenerator.setBrokerUrl(kafkaWithZKComponent.getBrokerList()); + broSampleDataGenerator.setNum(1); + broSampleDataGenerator.setSelectedSensorType("bro"); + broSampleDataGenerator.setDelay(0); + try { + while(!stop) { + broSampleDataGenerator.generateSampleData(path); } + } catch (IOException e) { --- End diff -- Good catch, absolutely. Thanks! > Intermittent unit test errors in the KafkaControllerIntegrationTest > ------------------------------------------------------------------- > > Key: METRON-773 > URL: https://issues.apache.org/jira/browse/METRON-773 > Project: Metron > Issue Type: Bug > Reporter: Casey Stella > Assignee: Casey Stella > > Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.514 sec <<< > FAILURE! - in org.apache.metron.rest.controller.KafkaControllerIntegrationTest > test(org.apache.metron.rest.controller.KafkaControllerIntegrationTest) Time > elapsed: 8.415 sec <<< FAILURE! > java.lang.AssertionError: Status expected:<200> but was:<404> > at > org.springframework.test.util.AssertionErrors.fail(AssertionErrors.java:54) > at > org.springframework.test.util.AssertionErrors.assertEquals(AssertionErrors.java:81) > at > org.springframework.test.web.servlet.result.StatusResultMatchers$10.match(StatusResultMatchers.java:664) > at > org.springframework.test.web.servlet.MockMvc$1.andExpect(MockMvc.java:171) > at > org.apache.metron.rest.controller.KafkaControllerIntegrationTest.test(KafkaControllerIntegrationTest.java:173) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:483) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:75) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at > org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86) > at > org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:84) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) > at > org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:252) > at > org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:94) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) > at > org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61) > at > org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70) > at org.junit.runners.ParentRunner.run(ParentRunner.java:363) > at > org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:191) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128) > at > org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) -- This message was sent by Atlassian JIRA (v6.3.15#6346)