[ 
https://issues.apache.org/jira/browse/METRON-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960771#comment-15960771
 ] 

ASF GitHub Bot commented on METRON-799:
---------------------------------------

Github user justinleet commented on a diff in the pull request:

    https://github.com/apache/incubator-metron/pull/518#discussion_r110385969
  
    --- Diff: 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/enrichment_commands.py
 ---
    @@ -131,47 +153,35 @@ def init_geo(self):
             self.set_geo_configured()
     
         def init_kafka_topics(self):
    -        Logger.info('Creating Kafka topics')
    -        command_template = """{0}/kafka-topics.sh \
    -                                --zookeeper {1} \
    -                                --create \
    -                                --topic {2} \
    -                                --partitions {3} \
    -                                --replication-factor {4} \
    -                                --config retention.bytes={5}"""
    -        num_partitions = 1
    -        replication_factor = 1
    -        retention_gigabytes = int(self.__params.metron_topic_retention)
    -        retention_bytes = retention_gigabytes * 1024 * 1024 * 1024
    -
    -        Logger.info("Creating topics for enrichment")
    -        topics = [self.__enrichment_topic]
    -        for topic in topics:
    -            Logger.info("Creating topic'{0}'".format(topic))
    -            Execute(command_template.format(self.__params.kafka_bin_dir,
    -                                            self.__params.zookeeper_quorum,
    -                                            topic,
    -                                            num_partitions,
    -                                            replication_factor,
    -                                            retention_bytes))
    -
    -        Logger.info("Done creating Kafka topics")
    +        Logger.info('Creating Kafka topics for enrichment')
    +        # All errors go to indexing topics, so create it here if it's not 
already
    +        metron_service.init_kafka_topics(self.__params, 
[self.__enrichment_topic, self.__params.metron_error_topic])
             self.set_kafka_configured()
     
    +    def init_kafka_acls(self):
    +        Logger.info('Creating Kafka topics')
    --- End diff --
    
    Yes, yes I did.


> The MPack should function in a kerberized cluster
> -------------------------------------------------
>
>                 Key: METRON-799
>                 URL: https://issues.apache.org/jira/browse/METRON-799
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Casey Stella
>            Assignee: Justin Leet
>              Labels: kerberos
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to