[
https://issues.apache.org/jira/browse/METRON-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963302#comment-15963302
]
ASF GitHub Bot commented on METRON-839:
---------------------------------------
GitHub user merrimanr opened a pull request:
https://github.com/apache/incubator-metron/pull/522
METRON-839: RPM build should happen after archives are built
## Contributor Comments
This PR separates the build process into 2 sequential tasks: Archive build
and RPM build. This ensures the archives have been built before RPMs are
created from them.
I tested this against full dev and verified the RPMs were properly created.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron (Incubating).
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root incubating-metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ x If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
bin/generate-md.sh
mvn site:site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommened that [travis-ci](https://travis-ci.org) is set up for
your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/merrimanr/incubator-metron METRON-839
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/522.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #522
----
commit 4a9bae4fb22e449fb4f1395faed9779ef53db537
Author: merrimanr <merrim...@gmail.com>
Date: 2017-04-10T18:25:03Z
Archive and RPM builds are now separate
----
> RPM build should happen after archives are built
> ------------------------------------------------
>
> Key: METRON-839
> URL: https://issues.apache.org/jira/browse/METRON-839
> Project: Metron
> Issue Type: Bug
> Reporter: Ryan Merriman
> Assignee: Ryan Merriman
>
> In the full-dev environment I am experiencing an issue where the rpm build
> process happens before the archives are built. This causes no rpms to be
> generated and full-dev fails when trying to install the Metron MPack.
> We need a way to ensure the archives are built first.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
