Junru Shao created MXNET-1398:
---------------------------------
Summary: Enable zero-copy from numpy to MXNet NDArray
Key: MXNET-1398
URL: https://issues.apache.org/jira/browse/MXNET-1398
Project: Apache MXNet
Issue Type: Improvement
Reporter: Junru Shao
## Description ##
This PR allows users to convert numpy's NDArray without copying content data.
This is achieved by converting numpy's NDArray to `DLManagedTensor`, which is
introduced in https://github.com/dmlc/dlpack/pull/38. We expect that this would
help users reduce major performance bottleneck when this conversion is
conducted frequently.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the
relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues)
created (except PRs with tiny changes)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a
new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing
distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new
build option with NCCL)
- [x] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments
are documented.
- For new examples, README.md is added to explain the what the example does,
the source of the dataset, expected performance on test set and reference to
the original paper if applicable
- Check the API doc at
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [x] To the my best knowledge, examples are either not affected by this
change, or have been fixed to be compatible with this change
### Changes ###
- [x] Rewrite `NDArray::FromDLPack` to make it resource safe.
- [x] Add DLManagedTensor and its deleter via ctypes that allows C++ side
deletes it.
## Comments ##
Nothing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
