rayjs opened a new issue #19436:
URL: https://github.com/apache/incubator-mxnet/issues/19436


   In the line 
https://github.com/apache/incubator-mxnet/blob/master/src/operator/grid_generator-inl.h#L103
   ```
          grid_dst[0] = range<DType>(0, grid_dst.shape_[1]);
           grid_dst[0] = grid_dst[0] - tcast<DType>(tcast<int>(grid_dst[0] /
             scalar<DType>(param_.target_shape[1]))) * 
scalar<DType>(param_.target_shape[1]);
           grid_dst[0] = scalar<DType>(-1.0) + grid_dst[0] *
             scalar<DType>(2.0 / (param_.target_shape[1] - 1));
           grid_dst[1] = range<DType>(0, grid_dst.shape_[1]);
           grid_dst[1] = scalar<DType>(-1.0) + 
tcast<DType>(tcast<int>(grid_dst[1] /
             scalar<DType>(param_.target_shape[1]))) * 
scalar<DType>(2.0/(param_.target_shape[0] - 1));
           grid_dst[2] = scalar<DType>(1.0);
   ```
   
   Should not this `scalar<DType>(param_.target_shape[1])` be  
`scalar<DType>(param_.target_shape[0])`?
   In this line
   `
   grid_dst[1] = scalar<DType>(-1.0) + tcast<DType>(tcast<int>(grid_dst[1] /
             scalar<DType>(param_.target_shape[1]))) * 
scalar<DType>(2.0/(param_.target_shape[0] - 1));
   `


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to