khaotik commented on issue #19950: URL: https://github.com/apache/incubator-mxnet/issues/19950#issuecomment-791129305
@TristonC Hello, first time contributor to MXNet here. I'm working on a PR for this. Here's my [branch](https://github.com/khaotik/incubator-mxnet/tree/adabelief-i19950). It's mostly a copycat of `src/operator/contrib/adamw*`. I'm still working on test cases. Question: Shall I send PR as is, or perhaps perform some code refactoring? I find rather high amount of code duplication upon working on this PR. Same goes for Adam-like optimizers such as STES, #18486. It might be good idea to generalize common parts of Adam-like optimizers. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org For additional commands, e-mail: issues-h...@mxnet.apache.org
