szha commented on issue #20149:
URL: 
https://github.com/apache/incubator-mxnet/issues/20149#issuecomment-818886227


   > Once it's feature complete, indeed, the unsafe version can be removed.
   
   I think it might take more than that. The current approach for making cached 
op thread-safe involves locks (see 
[here](https://github.com/apache/incubator-mxnet/blob/master/src/imperative/cached_op_threadsafe.cc#L162)).
 This has performance implication. Thus, in order to replace the 
non-thread-safe version, we may need a better approach for achieving 
thread-safety, such as making cachedop stateless.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@mxnet.apache.org
For additional commands, e-mail: issues-h...@mxnet.apache.org

Reply via email to