Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/675#discussion_r72243818
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/nifi.sh
 ---
    @@ -265,20 +265,54 @@ run() {
         BOOTSTRAP_DIR_PARAMS="${BOOTSTRAP_LOG_PARAMS} ${BOOTSTRAP_PID_PARAMS} 
${BOOTSTRAP_CONF_PARAMS}"
     
         RUN_NIFI_CMD="cd "\""${NIFI_HOME}"\"" && ${sudo_cmd_prefix} 
"\""${JAVA}"\"" -cp "\""${BOOTSTRAP_CLASSPATH}"\"" -Xms12m -Xmx24m 
${BOOTSTRAP_DIR_PARAMS}  org.apache.nifi.bootstrap.RunNiFi"
    +    LSB_EXIT_STATUS=0
    +    LSB_NIFI_STATUS_TEMPFILE=`mktemp -t 
LSB_NIFI_STATUS_TEMPFILE.XXXXXXXXXX`
     
         if [ "$1" = "start" ]; then
             (eval $RUN_NIFI_CMD $@ &)
    --- End diff --
    
    This seems like we would not be fulfilling the spec if nifi did not start 
appropriately.  I will get a 0 regardless if it starts successfully or not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to