Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/770 @olegz I just ran through some of these scenario's and everything looks good so far. However, with the new UUID generation strategy I think there is some dead code in SnippetUtils that should be cleaned up. Specifically, in SnippetUtils#copyContentsForGroup there is a serviceIdMap that was being used to update service identifiers in other component properties. Can we remove this code to help clean that up? Specifically, I think we can get rid of the serviceIdMap in SnippetUtils#copyContentsForGroup as well as both of the overloaded SnippetUtils#updateControllerServiceIdentifiers methods. Please can a peek to make sure we're on the same page. Leaving this code in place could lead to confusion down the road.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---