Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/843#discussion_r74689944
  
    --- Diff: 
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java
 ---
    @@ -90,20 +90,55 @@ public String toString() {
             }
         }
     
    +    // validator to ensure that valid EL expressions are used in the 
directory property
    +    static final Validator PATH_WITH_EL_VALIDATOR = new Validator() {
    --- End diff --
    
    Definitely agree this validator is not really specific to the HDFS 
processors and could be moved to the StandardValidators. Let me work on doing 
that. 
    
    The one that is already there expects only a single attribute expressions 
like "${hadoop.dir}"  and fails validation for something like 
"data/${hadoop.dir}" so that was why I had to create another one that uses 
newExpressionLanguageCompiler().validateExpression(input, true)  instead of 
newExpressionLanguageCompiler().compile(input)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to