Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/877#discussion_r75051853
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
 ---
    @@ -260,6 +310,20 @@ protected String getQuery(DatabaseAdapter dbAdapter, 
String tableName, String co
         }
     
     
    +    protected Map<String,String> getDefaultMaxValueProperties(final 
Map<PropertyDescriptor, String> properties){
    +        final Map<String,String> defaultMaxValues = new HashMap<String, 
String>();
    +
    +        for (final Map.Entry<PropertyDescriptor, String> entry : 
properties.entrySet()) {
    +            final String key = entry.getKey().getName();
    +
    +            if(!key.startsWith(INTIIAL_MAX_VALUE_PROP_START)) continue;
    --- End diff --
    
    Not sure (yet) if our checkstyle allows the one-line-if, but if you're 
already in here making changes, could you add the explicit braces? Superfluous 
I know, but consistent and extensible :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to