[
https://issues.apache.org/jira/browse/NIFI-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15448937#comment-15448937
]
ASF GitHub Bot commented on NIFI-2629:
--------------------------------------
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/969
@kirkalicious thanks for the PR! The concerning thing here is that we need
to make sure that any Processor, Controller Service, Reporting task that does
support dynamic properties actually has the @DynamicProperty annotation. The
annotation was placed in the 'org.apache.nifi.annotation.behavior' package
instead of 'org.apache.nifi.annotation.documentation' package, I believe, so
that we can do this sort of thing.
However, thus far, we have not enforced it, and we need to ensure that we
do not break backward compatibility. Doing a quick search of the codebase for
"getSupportedDynamicPropertyDescriptor" shows that there are at least a couple
of processors that do not have the @DynamicProperty annotation that should. At
a minimum, we should address those.
I do have some hesitation, though, that this could potentially break custom
processors in the same way, by no longer allowing users to add their own
properties.
@joewitt @mcgilman or any others have any thoughts on this?
> Hide add property "+" in Processors, Controller Services and Reporting Tasks
> that don't allow dynamic properties
> ----------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-2629
> URL: https://issues.apache.org/jira/browse/NIFI-2629
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework, Core UI
> Affects Versions: 0.7.0
> Reporter: Kirk Tarou
> Priority: Minor
>
> A few Processors, Controller Services and Reporting Tasks expect or allow
> extra properties to be added on the 'Properties' tab in the Detail view. The
> rest will show a "not a supported property" error.
> To avoid confusion, the new property "+" icon should be hidden if dynamic
> properties are not allowed.
> The existence of a "DynamicProperty" annotation could be used as an indicator.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
