Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/969 My only concern is the potential confusion over the API itself. This is currently driven by `getSupportedDynamicPropertyDescriptor` which can conditionally support a user defined property. The method is provided the property name that the user entered and it's responsible for generating the `PropertyDescriptor` for it. Because of this, the UI really can never know if dynamic properties should be supported. The `@DynamicProperty` annotation was added to assist with documentation. We could take a firmer stance and require the annotation but that could result in conflicting implementations (override `getSupportedDynamicPropertyDescriptor` but not adding `@DynamicProperty`) as @markap14 has pointed out. Once we've established this requirement however, we'd ultimately be better off as we'd be sure that the dynamic properties are documented. Because of this, I am in favor of the change though I also share the hesitation of breaking existing custom processors and when/how we can safely introduce it.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---