Github user jvwing commented on the issue:

    https://github.com/apache/nifi/pull/917
  
    Build with contrib-check passes OK.  The TravisCI failure was from memory 
("GC overhead limit exceeded"), not code issues.  All of my manual testing went 
well, both with and without versioning.  The code quality looks very good.
    
    One small thing -- the integration test 
ITListS3::testGetPropertyDescriptors fails due to the new property descriptors. 
 Would you please update that test?  Also, what would you think about a test or 
two for the versioning feature?  Even if you copy/pasted one of the existing 
integration tests and added `runner.setProperty(ListS3.USE_VERSIONS, "true");`, 
running it against the non-version-enabled bucket, it would still exercise the 
S3VersionBucketLister code paths.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to