Github user apiri commented on the issue:

    https://github.com/apache/nifi/pull/985
  
    Seems fair, although I would almost prefer that the two items get flipped 
in terms of testing.  Always run contrib check (without tests) during the build 
and then run the full test suite.  In the linked build, it seems the tests 
failure from the environment seemingly prevented the contrib check from 
running, which, as a reviewer, is typically the most time consuming part of the 
review process.
    
    Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to