[ 
https://issues.apache.org/jira/browse/NIFI-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510380#comment-15510380
 ] 

ASF GitHub Bot commented on NIFI-2756:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1004#discussion_r79869645
  
    --- Diff: 
nifi-maven-archetypes/nifi-processor-bundle-archetype/src/main/resources/archetype-resources/nifi-__artifactBaseName__-processors/src/main/java/MyProcessor.java
 ---
    @@ -41,7 +51,8 @@
     public class MyProcessor extends AbstractProcessor {
     
         public static final PropertyDescriptor MY_PROPERTY = new 
PropertyDescriptor
    -            .Builder().name("My Property")
    +            .Builder().name("MY_PROPERTY")
    --- End diff --
    
    Not that it matters, but most of the time I see machine-friendly names I've 
been seeing them like "my-processor-my-property" vs "MY_PROPERTY". Since it's a 
placeholder here, then no big deal, just sharing :)


> nifi-processor-bundle-archetype lacks displayName property
> ----------------------------------------------------------
>
>                 Key: NIFI-2756
>                 URL: https://issues.apache.org/jira/browse/NIFI-2756
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Andre
>            Assignee: Andre
>
> When using {{nifi-processor-bundle-archetype}} to create a new bundle, the 
> resulting code lacks displayName leading to a number of PR and contributions 
> to arrive to peer review without displayName configured



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to