fgerlits commented on a change in pull request #837:
URL: https://github.com/apache/nifi-minifi-cpp/pull/837#discussion_r458790534
##########
File path: CMakeLists.txt
##########
@@ -264,9 +264,12 @@ endif()
# spdlog
add_library(spdlog INTERFACE)
-target_include_directories(spdlog INTERFACE
"${CMAKE_CURRENT_SOURCE_DIR}/thirdparty/spdlog-20170710/include")
+target_include_directories(spdlog INTERFACE
"${CMAKE_CURRENT_SOURCE_DIR}/thirdparty/spdlog-1.7.0/include")
if (NOT WIN32)
set_property(TARGET spdlog APPEND PROPERTY
INTERFACE_COMPILE_DEFINITIONS "SPDLOG_ENABLE_SYSLOG")
+else()
+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DNOMINMAX")
Review comment:
this could go to the top level, around line 111, as
`add_definitions(-DNOMINMAX)`, I think
##########
File path: CMakeLists.txt
##########
@@ -264,9 +264,12 @@ endif()
# spdlog
add_library(spdlog INTERFACE)
-target_include_directories(spdlog INTERFACE
"${CMAKE_CURRENT_SOURCE_DIR}/thirdparty/spdlog-20170710/include")
+target_include_directories(spdlog INTERFACE
"${CMAKE_CURRENT_SOURCE_DIR}/thirdparty/spdlog-1.7.0/include")
if (NOT WIN32)
set_property(TARGET spdlog APPEND PROPERTY
INTERFACE_COMPILE_DEFINITIONS "SPDLOG_ENABLE_SYSLOG")
+else()
+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DNOMINMAX")
Review comment:
these could go to the top level, around line 111, as
`add_definitions(-DNOMINMAX)`, I think
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
