turcsanyip commented on a change in pull request #4422:
URL: https://github.com/apache/nifi/pull/4422#discussion_r460393047
##########
File path:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java
##########
@@ -152,6 +153,14 @@
.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
.build();
+ public static final PropertyDescriptor CACHE_CONTROL = new
PropertyDescriptor.Builder()
+ .name("Cache Control")
+ .displayName("Cache Control")
+ .description("Sets the Cache-Control HTTP header. Multiple
directives are comma-separated.")
Review comment:
@kent-nguyen The generic approach is to add EL support with Variable
Registry scope (`ExpressionLanguageScope.VARIABLE_REGISTRY`) at least and to
support Flow File attributes (`ExpressionLanguageScope.FLOWFILE_ATTRIBUTES`)
when it is reasonable.
Storage Class property also has the option "Reference parameter..."
(actually it is provided by the framework because it is a selectable property
with a drop-down list, but in fact it is similar to setting Variable Registry
scoped EL support from code).
As far as I see, you are not assigned the Contributor role yet. Could you
please request for "Jira contributor access" on the mailing list
d...@nifi.apache.org?
Then please assign the Jira ticket to yourself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
