adamdebreceni commented on a change in pull request #848:
URL: https://github.com/apache/nifi-minifi-cpp/pull/848#discussion_r463040371
##########
File path: extensions/libarchive/BinFiles.h
##########
@@ -91,7 +92,7 @@ class Bin {
if (flow->getAttribute(fileCount_, value)) {
try {
// for defrag case using the identification
- int count = std::stoi(value);
+ size_t count = std::stoul(value);
Review comment:
could use
```
uint32_t count;
utils::internal::ValueParser(value).parse(count).parseEnd()
```
##########
File path: extensions/libarchive/BinFiles.h
##########
@@ -91,7 +92,7 @@ class Bin {
if (flow->getAttribute(fileCount_, value)) {
try {
// for defrag case using the identification
- int count = std::stoi(value);
+ size_t count = std::stoul(value);
Review comment:
no `size_t` overload unfortunately
##########
File path: extensions/civetweb/tests/ListenHTTPTests.cpp
##########
@@ -169,7 +168,6 @@ class ListenHTTPTestsFixture {
}
protected:
- char* tmp_dir_format;
Review comment:
👍
##########
File path: libminifi/include/io/Serializable.h
##########
@@ -44,8 +44,9 @@ Integral byteSwap(Integral i) {
#ifdef htonll
return htonll(i);
#else
- #define htonll_r(x) ((((uint64_t)htonl(x)) << 32) + htonl((x) >> 32))
- return htonll_r(i);
+ uint32_t lower_32_bits = static_cast<uint32_t>(i);
Review comment:
are these two implementations equivalent? on big-endian systems `htonll`
is noop while the other one swaps the bytes anyway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
