szaszm commented on a change in pull request #854: URL: https://github.com/apache/nifi-minifi-cpp/pull/854#discussion_r463503005
########## File path: CMakeSettings.json ########## @@ -2,97 +2,97 @@ // See https://go.microsoft.com//fwlink//?linkid=834763 for more information about this file. "configurations": [ { - "name": "x64-Release", - "generator": "Visual Studio 15 2017 Win64", + "name": "x86-RelWithDebInfo", + "generator": "Visual Studio 15 2017", "configurationType": "RelWithDebInfo", - "inheritEnvironments": [ "msvc_x64_x64" ], + "inheritEnvironments": [ "msvc_x64_x86" ], Review comment: I think this environment is invalid. I would simply go for `msvc_x86`. https://docs.microsoft.com/en-us/cpp/build/cmakesettings-reference?view=vs-2019#environments ########## File path: CMakeSettings.json ########## @@ -2,97 +2,97 @@ // See https://go.microsoft.com//fwlink//?linkid=834763 for more information about this file. "configurations": [ { - "name": "x64-Release", - "generator": "Visual Studio 15 2017 Win64", + "name": "x86-RelWithDebInfo", + "generator": "Visual Studio 15 2017", "configurationType": "RelWithDebInfo", - "inheritEnvironments": [ "msvc_x64_x64" ], + "inheritEnvironments": [ "msvc_x64_x86" ], "buildRoot": "${env.USERPROFILE}\\CMakeBuilds\\${workspaceHash}\\build\\${name}", "installRoot": "${env.USERPROFILE}\\CMakeBuilds\\${workspaceHash}\\install\\${name}", "cmakeCommandArgs": "", - "buildCommandArgs": "-m -v:minimal", + "buildCommandArgs": "", Review comment: I think these empty `*CommandArgs` can be omitted. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
