adamdebreceni commented on a change in pull request #866:
URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r468380022
##########
File path: extensions/libarchive/MergeContent.cpp
##########
@@ -140,6 +146,10 @@ void MergeContent::onSchedule(core::ProcessContext
*context, core::ProcessSessio
if (context->getProperty(KeepPath.getName(), value) && !value.empty()) {
org::apache::nifi::minifi::utils::StringUtils::StringToBool(value,
keepPath_);
}
+ value = "";
+ if (context->getProperty(AttributeStrategy.getName(), value) &&
!value.empty()) {
+ this->attributeStrategy_ = value;
Review comment:
consistency, all others above this follow the same pattern, same for
resetting the `value`, I'm not sure if removing the `this` improves the code or
not
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
