adamdebreceni commented on a change in pull request #877:
URL: https://github.com/apache/nifi-minifi-cpp/pull/877#discussion_r475689892
##########
File path: extensions/rocksdb-repos/RocksDbStream.h
##########
@@ -160,7 +160,7 @@ class RocksDbStream : public io::BaseStream {
std::string value_;
- rocksdb::DB *db_;
+ gsl::not_null<minifi::internal::RocksDatabase*> db_;
Review comment:
I couldn't find a convincing argument either, only a gut feeling that
having `U f(T& t)` and `U g(T* t)`, after calling `g` I'm more reluctant to
discard the `t` I provided than after calling `f`, I feel like if I write `f`
I'm signaling that I only need the object for the duration of the function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
