adam-markovics commented on a change in pull request #863:
URL: https://github.com/apache/nifi-minifi-cpp/pull/863#discussion_r478353845
##########
File path: libminifi/test/flow-tests/FlowControllerTests.cpp
##########
@@ -193,7 +198,7 @@ TEST_CASE("Extend the waiting period during shutdown",
"[TestFlow4]") {
auto controller = testController.controller_;
auto root = testController.root_;
- int timeout_ms = 1000;
+ unsigned int timeout_ms = 1000;
Review comment:
As this is a duration its type could also be std::chrono::duration, with
no _ms suffix needed then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
