YolandaMDavis commented on a change in pull request #4522:
URL: https://github.com/apache/nifi/pull/4522#discussion_r497558154



##########
File path: nifi-api/src/main/java/org/apache/nifi/reporting/EventAccess.java
##########
@@ -63,4 +63,32 @@
      */
     List<Action> getFlowChanges(int firstActionId, final int maxActions);
 
+    /**

Review comment:
       @mattyb149 wondering if this interface can be simplified? In the 
implementation class (RingBufferEventRepository) the aggregatedValues object is 
used to produce these values by first converting that object to a 
flowFileEvent.  Can we  instead do a method like "reportAggregatedEvents" which 
returns a FlowFileEvent?  Then callers could just use that single FlowFileEvent 
to do getBytesRead/getBytesWritten etc. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to