lordgamez commented on a change in pull request #921:
URL: https://github.com/apache/nifi-minifi-cpp/pull/921#discussion_r503798155
##########
File path: extensions/civetweb/processors/ListenHTTP.cpp
##########
@@ -62,6 +62,17 @@ core::Property ListenHTTP::HeadersAsAttributesRegex("HTTP
Headers to receive as
" should be passed along
as FlowFile attributes",
"");
+core::Property ListenHTTP::BatchSize(
+ core::PropertyBuilder::createProperty("Batch Size")
+ ->withDescription("Maximum number of buffered requests to be processed
in a single batch. If set to zero all buffered requests are processed.")
+ ->withDefaultValue<std::size_t>(0)->build());
+
+core::Property ListenHTTP::BufferSize(
+ core::PropertyBuilder::createProperty("Buffer Size")
+ ->withDescription("Maximum number of HTTP Requests allowed to be
buffered before processing them when the processor is triggered. "
+ "If the buffer full, the request is refused. If set
to zero the buffer is unlimited.")
+ ->withDefaultValue<std::size_t>(0)->build());
+
Review comment:
That seems reasonable, thanks for the analysis. I changed the default to
20k in
[edf5b90](https://github.com/apache/nifi-minifi-cpp/pull/921/commits/edf5b9095ca7eeea4a1b2db4ba0ba58bec6632d0)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
