Github user trixpan commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1083#discussion_r81531262
  
    --- Diff: 
nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/test/java/org/apache/nifi/processors/email/TestConsumeEmail.java
 ---
    @@ -0,0 +1,180 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.nifi.processors.email;
    +
    +import com.icegreen.greenmail.user.GreenMailUser;
    +import com.icegreen.greenmail.util.GreenMail;
    +import com.icegreen.greenmail.util.ServerSetupTest;
    +import org.apache.nifi.util.MockFlowFile;
    +import org.apache.nifi.util.TestRunner;
    +import org.apache.nifi.util.TestRunners;
    +import org.junit.After;
    +import org.junit.Before;
    +import org.junit.Test;
    +import org.junit.Assert;
    +import org.springframework.integration.mail.AbstractMailReceiver;
    +
    +import javax.mail.Message;
    +import javax.mail.MessagingException;
    +import javax.mail.Session;
    +import javax.mail.internet.InternetAddress;
    +import javax.mail.internet.MimeMessage;
    +import java.lang.reflect.Field;
    +import java.util.List;
    +import java.util.Properties;
    +
    +import static org.junit.Assert.assertEquals;
    +
    +
    +public class TestConsumeEmail {
    --- End diff --
    
    The initial commit introduced a temporary test unit based on GreenMail, to 
avoid overlap, I gave it a different name. After user confirmed patch worked, I 
migrated some of the test you had created into the new jUnit.
    
    This allowed me to run debug the two test units while I was developing the 
final iteration of the test unit.
    
    I guess Test*.java was used was this naming convention used in other 
processors of the package, happy to rename back to the original if necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to