exceptionfactory opened a new pull request #4687:
URL: https://github.com/apache/nifi/pull/4687
#### Description of PR
NIFI-1930 Updated ListenHTTP to configure the Jetty SslContextFactory with
included protocols based on the configuration of the SSLContextService _TLS
Protocol_ property. The Jetty SslContextFactory will be configured to support
multiple current TLS protocol versions when the _TLS Protocol_ is configured
without a specific version. When the SSLContextService _TLS Protocol_ property
specifies a particular TLS Protocol version, only that version will be allowed.
This update simplifies the configuration of the Jetty SslContextFactory by
using the SSLContext created from SSLContextService, as opposed to passing the
individual key store and trust store properties. This update also introduces a
new _Client Auth_ property for ListenHTTP to explicitly define the TLS client
authentication policy. Previous versions of ListenHTTP inferred the client
authentication policy based on the presence or absence of trust store
properties in the SSLContextService. The _Client Auth_ property is defaulted
to REQUIRED to support mutual TLS authentication, but all standard values are
supported.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
